-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default_security_profile attribute to project #1374
Add default_security_profile attribute to project #1374
Conversation
e8ec6c5
to
07deb6d
Compare
/test-all |
nsxt/resource_nsxt_policy_project.go
Outdated
if err != nil { | ||
return err | ||
} | ||
return patchVpcSecurityProfile(d, connector, id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to wrap this in HasChange ("default_security_profile")
to avoid unnecessary call
nsxt/resource_nsxt_policy_project.go
Outdated
_, err := client.Get(defaultOrgID, projectID, "default") | ||
|
||
if isNotFoundError(err) && !enabled { | ||
// No action required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we dealing with the case in which default profile was not created yet? In this case, should we busy wait here?
07deb6d
to
8cf49ee
Compare
/test-all |
Add the attribute above and manage it vs the VpcSecurityProfiles client Signed-off-by: Kobi Samoray <[email protected]>
8cf49ee
to
aea3f25
Compare
/test-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use H-API to avoid two roundtrips but I don't think is worth it
Add the attribute above and manage it vs the VpcSecurityProfiles client